Refactor the thumbnail code #5673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates a couple of the JSDoc comments.
|
Review progress:
|
| /** | ||
| * @typedef {Object} PDFThumbnailViewOptions | ||
| * @property {HTMLDivElement} container - The viewer element. | ||
| * @property {number} id - The thumbnail unique ID (normally its number). |
There was a problem hiding this comment.
Nit: The thumbnail_'s_ unique ID
This includes an optimization to zero the height and width of existing thumbnail canvases, when they are removed and recreated during rotation of the document. (Credit goes to nnethercote, who initially found this in PR 4920.)
This is useful if thumbnails are being rendered when the document is rotated, since it let us abort the current rendering.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/2c4a232f9f32c32/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/2c4a232f9f32c32/output.txt Total script time: 0.79 mins Published |
|
file and symbols dependencies look good |
timvandermeij
added a commit
that referenced
this pull request
Jan 26, 2015
Refactor the thumbnail code
|
Awesome work! |
This was referenced Jan 26, 2015
Merged
speedplane
pushed a commit
to speedplane/pdf.js
that referenced
this pull request
Feb 24, 2015
Refactor the thumbnail code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites part of the thumbnail code to achieve the following goals:
ThumbnailViewimplementation to be class-like.ThumbnailViewcode to be more in-line with the correspondingPagecode. (Even though thePagecode has evolved quite a bit, theThumbnailcode hasn't usually followed suite.)To actually make it feasible to review this, I've divided the PR into multiple patches. The commit messages should hopefully be clear enough to explain what is going on. Also, for some of the larger patches, using the
?w=1URL flag should help.I've made sure that at every point in the patch series, the code actually works. However, before landing this, I'm assuming that we might want to merge a few of the (smaller) commits together. But in order to make it somewhat easier to deal with any (hopefully non-existent) regressions, landing this as one big patch is probably not the best idea.