[l10n] Treat language as case-insensitive #5692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See "Case-insensitive language comparisons per RFC 4646" fabi1cazenave/webL10n#51 Removed the "patch" in compatibility.js and fixed the bug in webL10n, because the logic belongs to webL10n instead of PDF.js. The immediate motivation for this patch is that Chrome 40 converts navigator.language to lower case: https://crbug.com/454331
|
@yurydelendik This patch has been merged upstream in the meantime. Could you review this so we can merge it here too? |
yurydelendik
added a commit
that referenced
this pull request
Mar 10, 2015
[l10n] Treat language as case-insensitive
|
Thank you for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 4646 specifies that language tags should be treated case-insensitively, so the previous work-around to #4335 is insufficient: The patch should not be added to compatibility.js, but become a part of the l10n library.
See "Case-insensitive language comparisons per RFC 4646" @ fabi1cazenave/webL10n#51
(I've created this patch because I've noticed that
navigator.languageis lowercase in Chrome 40: https://code.google.com/p/chromium/issues/detail?id=454331)