-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the |el| property in PDFPageView and PDFThumbnailView #5711
Remove the |el| property in PDFPageView and PDFThumbnailView #5711
Conversation
how will a developer know that this has been deprecated? |
I agree with @CodingFabian. I'm fairly sure no-one is using this, and if so they will notice soon enough that it has been deprecated if we remove it. If we keep enabling it for generic builds, most people wouldn't notice that it's deprecated I think. |
We're not currently versioning the viewer API and we warn about this in the getting started code. Let's just wipe this out. |
It's gone now! /botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/4b909cc4e3db544/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/4b909cc4e3db544/output.txt Total script time: 1.15 mins Published |
Remove the |el| property in PDFPageView and PDFThumbnailView
Thank you |
Remove the |el| property in PDFPageView and PDFThumbnailView
Obviously it would have been nicer to just remove it all together, but in the event that some third-party implementation depends on it, I figured that we might want to keep it around forGENERIC
builds for now.