Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the |el| property in PDFPageView and PDFThumbnailView #5711

Merged
merged 1 commit into from
Feb 27, 2015
Merged

Remove the |el| property in PDFPageView and PDFThumbnailView #5711

merged 1 commit into from
Feb 27, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

Obviously it would have been nicer to just remove it all together, but in the event that some third-party implementation depends on it, I figured that we might want to keep it around for GENERIC builds for now.

@CodingFabian
Copy link
Contributor

how will a developer know that this has been deprecated?
right now i would even prefer to remove this (its not really public api). Developers building on the code would quickly see that el no longer exist and could easily rewrite to use the div element.

@timvandermeij
Copy link
Contributor

I agree with @CodingFabian. I'm fairly sure no-one is using this, and if so they will notice soon enough that it has been deprecated if we remove it. If we keep enabling it for generic builds, most people wouldn't notice that it's deprecated I think.

@Snuffleupagus
Copy link
Collaborator Author

I only left el for GENERIC builds as a matter of consistency, since we've done similar things with other code, e.g. this and also this. But in this particular case, I don't have a strong opinion either way.

@brendandahl
Copy link
Contributor

We're not currently versioning the viewer API and we warn about this in the getting started code. Let's just wipe this out.

@Snuffleupagus Snuffleupagus changed the title Deprecate the |el| property in PDFPageView and PDFThumbnailView Remove the |el| property in PDFPageView and PDFThumbnailView Feb 26, 2015
@Snuffleupagus
Copy link
Collaborator Author

It's gone now!

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/4b909cc4e3db544/output.txt

yurydelendik added a commit that referenced this pull request Feb 27, 2015
Remove the |el| property in PDFPageView and PDFThumbnailView
@yurydelendik yurydelendik merged commit 6ead5c4 into mozilla:master Feb 27, 2015
@yurydelendik
Copy link
Contributor

Thank you

@Snuffleupagus Snuffleupagus deleted the deprecate-el-property branch February 27, 2015 14:41
speedplane pushed a commit to speedplane/pdf.js that referenced this pull request Mar 4, 2015
Remove the |el| property in PDFPageView and PDFThumbnailView
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants