Correctly detect the presence of the Adobe specific APP14 JPEG marker (bug 1140761) #5821
Conversation
… (bug 1140761) According to the specification, http://partners.adobe.com/public/developer/en/ps/sdk/5116.DCT_Filter.pdf#G3.851943, the content of the marker segment should begin with `Adobe`, and not `Adobe\x00` as the code currently look for. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1140761. Fixes the colour conversion part of issues 4090 and 5623.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/9868d40139d6358/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/9868d40139d6358/output.txt Total script time: 0.95 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b4d506aa781ccf3/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/8130024161edede/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b4d506aa781ccf3/output.txt Total script time: 17.82 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/8130024161edede/output.txt Total script time: 22.05 mins
|
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/65f27872fb02856/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/088baae812a2659/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/65f27872fb02856/output.txt Total script time: 19.24 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/088baae812a2659/output.txt Total script time: 22.58 mins
|
Correctly detect the presence of the Adobe specific APP14 JPEG marker (bug 1140761)
|
Nice! Thanks! |
According to the specification, http://partners.adobe.com/public/developer/en/ps/sdk/5116.DCT_Filter.pdf#G3.851943, the content of the marker segment should begin with
Adobe, and notAdobe\x00as the code currently look for.Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1140761.
Fixes the colour conversion part of issues #4090 and #5623.
Note: Thus far I've been unable to find anything other than a hacky work-around for the remaining issue,
"Error: JPEG error: marker was not found", but I figured I would submit this PR anyway since it at least solves one part of the problem.