Fix flaw in mozCurrentTransform polyfill #5828
Conversation
Set transformation matrix in (polyfilled) mozPrintCallback when a scale is applied. Removed _scaleX and _scaleY in favor of _transformMatrix to emphasize that the caller MUST ensure that the state of the matrix is correct before `addContextCurrentTransform` is called.
|
This patch is easy to comprehend and verify, so could you review+merge it? |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ad5790326396966/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/ad5790326396966/output.txt Total script time: 0.83 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/f0140bf47ec47da/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/33528ec4fc6cd92/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/f0140bf47ec47da/output.txt Total script time: 20.53 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/33528ec4fc6cd92/output.txt Total script time: 23.00 mins
|
|
Fixes #5800. |
Fix flaw in mozCurrentTransform polyfill
|
Thank you for the patch (fixes three issues), and sorry for the delay! |
Set transformation matrix in (polyfilled) mozPrintCallback when a scale is applied, and removed
ctx._scaleXandctx._scaleYin favor ofctx._transformMatrixto emphasize that the caller MUST ensure that the state of the matrix is correct beforeaddContextCurrentTransformis called.To verify that the bug is fixed:
node make server)Fixes #5505
Fixes #5827
(note: these bugs have been marked as Chrome-specific, but the bug is actually more general, it applies to every non-Firefox browser).