Re-factor and clean-up some preference related code in viewer.js #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rApplication.initialize| For consistency, this preference should be placed amongst the others. The current position is purely for "historical" reasons, since it was one of the first preferences that was added to the code.
…wOnLoad| preference is set to |false| Since this code is *only* necessary if/when the history is actually enabled, this patch refactors it to actually reflect that.
…tialView| This is a minor cleanup, to avoid an unnecessary `Promise.all` and to simplify catching |ViewHistory| errors.
Snuffleupagus
changed the title
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/edb27b4bfd2a2c2/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/edb27b4bfd2a2c2/output.txt Total script time: 0.82 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Apr 1, 2015
Re-factor and clean-up some preference related code in viewer.js
|
Nice refactoring, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, please refer to the individual commit messages.
These patches slightly re-factors the handling of a couple of preferences in viewer.js, and also simplifies the code that sets the initial document position on load.
Edit: Also, the
?w=1URL flag should simplify things when reviewing the last patch!