prevent viewer from zooming on cmd+mousewheel (bug 1018932) #5926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that this is my first contribution to a Mozilla project, so style or workflow feedback is appreciated. |
|
@browtayl Please squash the commits, see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits. |
|
@Snuffleupagus squashed. |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d6b1858bae97e5d/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/d6b1858bae97e5d/output.txt Total script time: 0.78 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Apr 13, 2015
prevent viewer from zooming on cmd+mousewheel (bug 1018932)
|
Thank you for the patch! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in bug 1018932, the viewer toolbar resizes with the content when zooming with cmd+mousewheel.
This pull request adds a condition to the mousewheel handler to check if the metakey is pressed, in which case toolbar zoom is prevented.