Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail with a more informative error message if the browser executable pat... #5944

Conversation

marco-c
Copy link
Contributor

@marco-c marco-c commented Apr 17, 2015

...h doesn't exist

@timvandermeij
Copy link
Contributor

Verified that this does give a much more informative error message locally, but for the sake of completeness let's run the tests.

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/509931174b7cfda/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/167e3de497faca5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/509931174b7cfda/output.txt

Total script time: 18.47 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/167e3de497faca5/output.txt

Total script time: 22.67 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

timvandermeij added a commit that referenced this pull request Apr 17, 2015
…_path_doesnt_exist

Fail with a more informative error message if the browser executable pat...
@timvandermeij timvandermeij merged commit 62c3db0 into mozilla:master Apr 17, 2015
@timvandermeij
Copy link
Contributor

Thank you!

@marco-c marco-c deleted the better_error_message_if_browser_path_doesnt_exist branch April 17, 2015 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants