Bug 1156287 - Do not extract unreachable code after return

[arai-a]

https://bugzilla.mozilla.org/show_bug.cgi?id=1156287

I'm going to add warning for unreachable code after return statement in https://bugzilla.mozilla.org/show_bug.cgi?id=1151931 , and it hits following code.

http://mxr.mozilla.org/mozilla-central/source/browser/extensions/pdfjs/content/web/viewer.js#6818

  PDFViewerApplication.setTitleUsingUrl(file);
  PDFViewerApplication.initPassiveLoading();
  return;


  if (file) {
    PDFViewerApplication.open(file, 0);
  }
}

Those are extracted from following code in upstream.

https://github.com/mozilla/pdf.js/blob/master/web/viewer.js#L1661

//#if (FIREFOX || MOZCENTRAL)
//PDFViewerApplication.setTitleUsingUrl(file);
//PDFViewerApplication.initPassiveLoading();
//return;
//#endif

https://github.com/mozilla/pdf.js/blob/master/web/viewer.js#L1689

//#if !B2G && !CHROME
  if (file) {
    PDFViewerApplication.open(file, 0);
  }
//#endif

if former code is extracted, latter one won't be reachable, so it shouldn't be extracted if (FIREFOX || MOZCENTRAL) is true.

[Snuffleupagus]

Since this preprocessor line is identical to GENERIC, why not just move this code:

if (file) {
  PDFViewerApplication.open(file, 0);
}

to after line 1686 instead?

[arai-a]

Thank you for letting me know that, added the patch for it :)

[Snuffleupagus]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5b85c9b53aa4703/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/5b85c9b53aa4703/output.txt

Total script time: 0.80 mins

Published

• Viewer: http://107.21.233.14:8877/5b85c9b53aa4703/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/5b85c9b53aa4703/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/5b85c9b53aa4703/extensions/firefox/pdf.js.xpi

[Snuffleupagus]

Thank you for the patch!