Enable linting of Firefox specific code in viewer.js #5966
Conversation
|
Doing this actually uncovered some issues, e.g. variables defined multiple times. Are these also addressed in this patch or are these changes only to enable linting? |
Yes. And sorry about not mentioning that, since I now see the potential for confusion! The |
| var versionId = String(info.PDFFormatVersion).slice(-1) | 0; | ||
| var generatorId = 0; | ||
| var KNOWN_GENERATORS = [ | ||
| 'acrobat distiller', 'acrobat pdfwritter', 'adobe livecycle', |
There was a problem hiding this comment.
While we're here, can be change acrobat pdfwritter to acrobat pdfwriter (i.e., one t)? If you can mention that change in the commit description, then it's fine to do it in this commit I think.
There was a problem hiding this comment.
Absolutely great catch, thank you!
This should explain why the telemetry stats are empty for bucket 2, see e.g. the telemetry data for Firefox 36 and the enumeration reference.
There was a problem hiding this comment.
You're right, I hadn't even noticed that. I have already updated the wiki page (where the typo was also visible), so if we fix it here too than that problem is also resolved.
- This patch uncomments a large portion of the Firefox specific code in viewer.js, by using a preprocessor "trick", to enable linting. Doing this actually uncovered some issues, e.g. variables defined multiple times. - This patch also fixes a spelling error, `adobe pdfwritter` -> `abobe pdfwriter`, in the `KNOWN_GENERATORS` list used when reporting telemetry data in Firefox. *Please note:* there's still some Firefox specific code that is commented out, but it's usually just one (or two) lines of code. Hence the risk that errors creep in should be much lower, compared to entire code-blocks.
|
I've confirmed, with the built addon, that /botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/5c34e967260ea5d/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5c34e967260ea5d/output.txt Total script time: 0.83 mins Published |
…code Enable linting of Firefox specific code in viewer.js
adobe pdfwritter->abobe pdfwriter, in theKNOWN_GENERATORSlist used when reporting telemetry data in Firefox.Please note: there's still some Firefox specific code that is commented out, but it's usually just one (or two) lines of code. Hence the risk that errors creep in should be much lower, compared to entire code-blocks.