Bug 1122280 - Handle UTF-8 encoding in URI #5999
Conversation
|
Once you have addressed these comments, could you make sure to squash the commits into one? See https://github.com/mozilla/pdf.js/wiki/Squashing-Commits on how to do this easily if you are not familiar with squashing commits. Thank you! |
…oper 7-bit ASCII this makes no difference. Fixes Bug 1122280.
hellemar
force-pushed
the
handle-utf8-in-url
branch
from
c8db9eb to
a61a4b1
Compare
|
Thanks for the comments, I have updated the code comments to address them. |
|
Is there anything I should do to run the automatic tests on the squashed commit or is it unnecessary since only code comments have been changed? |
|
I will trigger the tests right now. They will run once tests for another PR are finished. /botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://107.21.233.14:8877/9099995ead2e44a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://107.22.172.223:8877/d456f8126f5dd46/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/d456f8126f5dd46/output.txt Total script time: 19.48 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/9099995ead2e44a/output.txt Total script time: 22.89 mins
|
|
/botio lint |
From: Bot.io (Linux)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/35fc2c2d23fe980/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/119ba8652e8c2b5/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/35fc2c2d23fe980/output.txt Total script time: 0.89 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/119ba8652e8c2b5/output.txt Total script time: 1.11 mins
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/2d812dfa51813d6/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/2d812dfa51813d6/output.txt Total script time: 0.87 mins Published |
Bug 1122280 - Handle UTF-8 encoding in URI
|
Thank you for the patch! |
URL annotations handled as UTF-8 to accommodate some bad PDFs. For proper 7-bit ASCII this makes no difference. Fixes Bug 1122280.
Reasoning:
According to ISO 32000-1:2008, section 12.6.4.7, URI should be encoded in 7-bit ASCII, i.e. not handling UTF-8 in URI is, strictly speaking, not a bug.
However some bad PDFs may have URIs in UTF-8 encoding and other PDF viewers are able to produce the intended result.