viewer: Support Retina/HiDPI thumbnails #6025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Recommend merging #6026 alongside this to avoid UI stutter on lower end HiDPI systems. |
| return canvas.getContext('2d'); | ||
| var ctx = canvas.getContext('2d'); | ||
| var outputScale = getOutputScale(ctx); | ||
| canvas.width = this.canvasWidth * outputScale.sx; |
There was a problem hiding this comment.
Please make sure that canvas.width is an integer, by changing this line to:
canvas.width = (this.canvasWidth * outputScale.sx) | 0;And similar for canvas.height on the next line.
Reuse the existing getOutputScale() machinery to render and/or rescale thumbnail images to the native display resolution. Fixes blurry thumbnails on HiDPI displays making it a lot easier to make out the content.
|
Thanks for the review comments @Snuffleupagus. All points addressed and commits are now squashed. |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/5679bd047e9ce34/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5679bd047e9ce34/output.txt Total script time: 0.72 mins Published |
timvandermeij
added a commit
that referenced
this pull request
May 19, 2015
viewer: Support Retina/HiDPI thumbnails
|
Thank you for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse the existing getOutputScale() machinery to render and/or rescale
thumbnail images to the native display resolution. Fixes blurry thumbnails on
HiDPI displays making it a lot easier to make out the content.