Apply padding on <select>, not the button

[TimothyGu]

Fixes clicking the edge of the zoom selection dropdown button.

[timvandermeij]

The dropdown is now too close to the loading bar. Maybe it's because the top padding is increased?

After you have adjusted that, could you squash the commits into one? See https://github.com/mozilla/pdf.js/wiki/Squashing-Commits on how to do that easily.

[TimothyGu]

The dropdown is now too close to the loading bar. Maybe it's because the top padding is increased?

This is an intentional change. IMO it looks really odd to have the +/- buttons fairly big and centered vertically, then have the dropdown right next to it not aligned with the buttons:

After you have adjusted that, could you squash the commits into one?

Absolutely. I intentionally used separate commits since they technically are separate changes.

[Snuffleupagus]

This is an intentional change. IMO it looks really odd to have the +/- buttons fairly big and centered vertically, then have the dropdown right next to it not aligned with the buttons:

As @timvandermeij alluded to above, this PR unfortunately "breaks" in Firefox.
Given that the primary use-case for the default viewer is to be the UI for the built-in PDF viewer in Firefox, we cannot accept a PR that regresses Firefox (even if it would happen to fix something in other browsers). This is what the latest version of this PR looks like in Firefox 41:

[TimothyGu]

@Snuffleupagus I totally understand. However I cannot reproduce your issue locally on Firefox 38.0 as bundled with Ubuntu. Testing Windows right now. Yes I can reproduce it now. Odd.

But regardless I reverted the controversial padding change so it should be as it was.

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/1cce7d0a8ec8209/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/1cce7d0a8ec8209/output.txt

Total script time: 0.71 mins

Published

• Viewer: http://107.21.233.14:8877/1cce7d0a8ec8209/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/1cce7d0a8ec8209/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/1cce7d0a8ec8209/extensions/firefox/pdf.js.xpi

[TimothyGu]

Ping; any further comments?

[timvandermeij]

Thank you for the patch!