Increase the font weight used for non-embedded ArialBlack fonts #6091
Conversation
Currently non-embedded ArialBlack fonts are not rendered bold enough, compared to e.g. Adobe Reader. The issue is that we set the font weight to `bolder`, but since that is actually relative to the font weight of the parent, the result is that there's no practical difference from just using `bold`. This patch attempts to address that, by explicitly setting the font weight to the maximum value instead (see https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight). *Note:* I expect one test "failure" in `issue5801`, which in this case is an improvement, since that PDF file uses ArialBlack.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/0c426bfa4792182/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/0c426bfa4792182/output.txt Total script time: 17.92 mins
|
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/5fbc362bb144a03/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/5fbc362bb144a03/output.txt Total script time: 18.42 mins
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1fa171c6c869714/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/1fa171c6c869714/output.txt Total script time: 0.70 mins Published |
|
I can confirm that this looks better for me too on Windows 7 x64 with HWA on. Now it renders like Adobe Acrobat for me. |
Not failures (so for botio it's undetectable). Looks good. Thanks. |
Increase the font weight used for non-embedded ArialBlack fonts
Currently non-embedded ArialBlack fonts are not rendered bold enough, compared to e.g. Adobe Reader.
The issue is that we set the font weight to
bolder, but since that is actually relative to the font weight of the parent, the result is that there's no practical difference from just usingbold.This patch attempts to address that, by explicitly setting the font weight to the maximum value instead (see https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight).
Note: I expect one test "failure" in
issue5801, which in this case is an improvement, since that PDF file uses ArialBlack.Edit: Apparently this made no difference on the bots. But it does improve things locally for me, when testing on Windows with HWA on. However, with HWA switched off, the patch doesn't seem to help.
Hence it seems that whether or not this patch improves things, is connected with the HWA setting.