Slightly improved Crypto unit tests #6093
Conversation
|
Aside from the comment above this looks really good! |
Currently in the tests which check that incorrect passwords are rejected, we don't ensure that the exceptions thrown are the ones we expect. This patch improves the current situation, so that we actually can be sure that the code "fails" in the correct way. *Note:* This patch also fixes some cases of weird indentation in the file.
|
The function name was shortened. /botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/dcdb1784b07bf24/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d303d3cc9e91028/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/d303d3cc9e91028/output.txt Total script time: 0.60 mins
|
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/dcdb1784b07bf24/output.txt Total script time: 0.93 mins
|
|
/botio unittest |
From: Bot.io (Linux)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/4eccbcd561b934e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/24116262dc5651c/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/4eccbcd561b934e/output.txt Total script time: 0.62 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/24116262dc5651c/output.txt Total script time: 0.95 mins
|
…unittests Slightly improved Crypto unit tests
|
Looks good, thanks! |
Currently in the tests which check that incorrect passwords are rejected, we don't ensure that the exceptions thrown are the ones we expect. This patch improves the current situation, so that we actually can be sure that the code "fails" in the correct way.
Note: This patch also fixes some cases of weird indentation in the file.
Edit: Easier reviewing with https://github.com/mozilla/pdf.js/pull/6093/files?w=1.