-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further improvements of the getStats and getDownloadInfo unit tests #6147
Further improvements of the getStats and getDownloadInfo unit tests #6147
Conversation
The patch adds a test to ensure that `getStats` returns the expected result after the page has been parsed, and cleans up the existing test a bit. Also, since I'm touching the file anyway, I'm making a small adjustment of the `getDownloadInfo` test. (I have no idea why I didn't just write it like this initially.)
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/d0fea0e7837f0c4/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/9b0b689c0559b01/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/9b0b689c0559b01/output.txt Total script time: 0.61 mins
|
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/d0fea0e7837f0c4/output.txt Total script time: 0.67 mins
|
/botio-windows test looks good |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://107.22.172.223:8877/63996e900855136/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/63996e900855136/output.txt Total script time: 17.97 mins
|
Thank you for the patch. |
…tStats-getDownloadInfo Further improvements of the getStats and getDownloadInfo unit tests
The patch adds a test to ensure that
getStats
returns the expected result after the page has been parsed, and cleans up the existing test a bit.Also, since I'm touching the file anyway, I'm making a small adjustment of the
getDownloadInfo
test. (I have no idea why I didn't just write it like this initially.)