-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom relative to cursor position via mouse wheel #6170
Conversation
Before this patch, zooming in/out via the scroll wheel caused the page to be zoomed relative to the upper-left corner of the page, i.e. the upper-left corner of the page stays at a fixed position. After this patch, the page is zoomed relative to the cursor position, i.e. after zooming in/out, the part under the cursor 'has not moved'. This only applies when the page does not fit in the viewport, because pages smaller than the viewpoer are always centered.
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 1 Live output at: http://107.22.172.223:8877/25830a6f1c76237/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/25830a6f1c76237/output.txt Total script time: 0.88 mins Published |
I had previously verified that the patch works in Firefox 38 and Chromium 43 on Linux. Now I've also manually tested this patch in various browsers/OSs at BrowserStack, by visiting http://107.22.172.223:8877/25830a6f1c76237/web/viewer.html and following the steps in the PR description. Windows 7
Windows 10
OS X 10.8 (Mountain Lion)
OS X 10.9 (Mavericks)
OS X 10.10 (Yosemite)
@yurydelendik Could you check whether this PR works fine on OS X in Firefox & Safari? If yes, then the PR can be merged. |
It works on ff & safari. Thank you for the patch. |
Zoom relative to cursor position via mouse wheel
Nice feature, thank you @Rob--W! |
This patch works fine when testing Running |
@Andersw88 This patch will be included in Firefox 42 (according to the "Target Milestone" field in bug 1182228), which is scheduled for release on 2015-11-03. |
Before this patch, zooming in/out via the scroll wheel caused the page to be zoomed relative to the upper-left corner of the page, i.e. the upper-left corner of the page stays at a fixed position.
After this patch, the page is zoomed relative to the cursor position, i.e. after zooming in/out, the part under the cursor 'has not moved'.
This only applies when the page does not fit in the viewport, because pages smaller than the viewpoer are always centered.
To verify that the patch works as intended:
During step 3 and 4, the PDF under the page position under the cursor should be fixed.