[CRX] Ignore PDFs from responses to POST requests #6176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in mozilla#6174 (comment). To verify that this patch works: 1. Build the Chrome extension (node make chromium) 2. Load the Chrome extension (at chrome://extensions) 3. Visit https://robwu.nl/pdfjs/issue6174/. 4. Verify that PDF.js is not used to load the PDF. Either Chrome's default PDF Viewer is used, or the PDF is offered as a file download.
Snuffleupagus
added a commit
that referenced
this pull request
Jul 5, 2015
[CRX] Ignore PDFs from responses to POST requests
|
Confirmed to be working as described, using the built extension in: Google Chrome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #6174 (comment).
To verify that this patch works:
(verified with Chromium 43.0.2357.81 and 45.0.2445.0 on Linux)