Fetch all indirect objects (i.e. Refs) in NameTree_getAll and NameTree_get (issue 6204)
#6208
Conversation
…meTree_get` (issue 6204)
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/fa9c499ba285cc4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/da6be444ba43d2e/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/da6be444ba43d2e/output.txt Total script time: 18.21 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/fa9c499ba285cc4/output.txt Total script time: 18.96 mins
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/65b27d23036cbbc/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/65b27d23036cbbc/output.txt Total script time: 0.67 mins Published |
Fetch all indirect objects (i.e. `Ref`s) in `NameTree_getAll` and `NameTree_get` (issue 6204)
|
Looks good, thanks! |
- NumTree (7.9.7) is almost identical to NameTree, so the NameTree class was slightly refactored and re-used by NumTree. - Generalized the comments / variables in NameTree. The previous code was extremely biased towards its use in destinations. - Improved the getter performance by caching the result of fetchIfRef instead of calling it twice in the .get() method of NameTree. - Add unit tests. The existing tests are not sufficient, e.g. undoing the changes in .get() from mozilla#6208 did not cause test failures...
Fixes #6204.