Fix regressions affecting both the 'pagemode' hash parameter and certain 'namedaction' types (PR 5971) #6314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…store the functionality This regressed in 0ef6212. Since the 'pagemode' hash parameter requires certain viewer functionality (e.g. thumbnails and an outline) in order to work, it seemed reasonable to move the functionality from `pdf_link_service.js` into `viewer.js`. Similar to `namedaction`, this patch makes use of an event to forward the 'pagemode' parameter.
This regressed in 0ef6212.
|
I removed the unnecessary newline; I also made a couple of small improvements in the first commit, e.g. better code structure (and added comments) for the /botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/c137f33485137fc/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/c137f33485137fc/output.txt Total script time: 0.99 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Aug 7, 2015
Fix regressions affecting both the 'pagemode' hash parameter and certain 'namedaction' types (PR 5971)
|
Nice patch, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages.
Both these regressions are from PR #5971.