Prevent switching to disabled views (i.e. outline or attachments) in the sidebar #6327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the sidebar Currently in `switchSidebarView` there is code that attempts to handle the `outline` or `attachments` being disabled. However, given the placement of it, that code does not actually accomplish anything. Even more strange is the fact that the way that the buttons are disabled, that code won't ever be hit. (Looking back with `git blame`, it seems that it has never worked as you'd expect.) Hence this patch, which correctly disables switching to the `outline` or `attachments` views when they are disabled. Once PR 6314 restores the 'pagemode' hash parameter, this patch thus makes it impossible to switch to a disabled sidebar view by modifying the 'pagemode' hash of an already loaded document.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 1 Live output at: http://107.21.233.14:8877/60f71bf65c45139/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/60f71bf65c45139/output.txt Total script time: 0.64 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Aug 7, 2015
…itching-to-disabled-views Prevent switching to disabled views (i.e. outline or attachments) in the sidebar
|
Good patch, thanks! |
Snuffleupagus
deleted the
viewer-sidebar-prevent-switching-to-disabled-views
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in
switchSidebarViewthere is code that attempts to handle theoutlineorattachmentsbeing disabled. However, given the placement of it, that code does not actually accomplish anything. Even more strange is the fact that the way that the buttons are disabled, that code won't ever be hit.(Looking back with
git blame, it seems that it has never worked as you'd expect.)Hence this patch, which correctly disables switching to the
outlineorattachmentsviews when they are disabled.Once PR #6314 restores the 'pagemode' hash parameter, this patch thus makes it impossible to switch to a disabled sidebar view by modifying the 'pagemode' hash of an already loaded document.