Serialize errors before invoking postMessage #6332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes (when an error occurs), PDF.js gets stuck. The viewer is then indefinitely waiting for a promise to resolve, which never happens because of the DataCloneError. This PR addresses the issue by converting the error to a string before throwing.
Firefox: "DataCloneError: The object could not be cloned."
Chrome: "DataCloneError: Failed to execute 'postMessage' on 'WorkerGlobalScope': An object could not be cloned."
Here's an isolated test case, if you want to see what happens when an Error object is passed to
postMessage
: