Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locatization notes for the DocumentProperties strings with parameters #6369

Merged
merged 1 commit into from
Aug 26, 2015
Merged

Add locatization notes for the DocumentProperties strings with parameters #6369

merged 1 commit into from
Aug 26, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

This should hopefully help prevent localizers from translating the actual parameters.

…ters

This should hopefully help prevent localizers from translating the actual parameters.
@Snuffleupagus
Copy link
Collaborator Author

According to https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices, it seems that we don't need to change string IDs if we're only adding localization notes.

yurydelendik added a commit that referenced this pull request Aug 26, 2015
…nt-properties

Add locatization notes for the DocumentProperties strings with parameters
@yurydelendik yurydelendik merged commit 63ed681 into mozilla:master Aug 26, 2015
@yurydelendik
Copy link
Contributor

Looks good. Thanks

@Snuffleupagus Snuffleupagus deleted the localization-notes-document-properties branch August 26, 2015 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants