Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the clipping path is reset when the state is restored (issue 6413) #6414

Merged
merged 2 commits into from
Sep 4, 2015
Merged

Ensure that the clipping path is reset when the state is restored (issue 6413) #6414

merged 2 commits into from
Sep 4, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

According to the specification, see NOTE 2 in http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.3882161, it appears that we should ensure that the clipping path is reset when the restore (Q) operator is encountered.

Fixes #6413.

Note: I'm currently trying to create a reduced test-case, hence the WIP label.

…sue 6413)

According to the specification, see `NOTE 2` in http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G7.3882161, it appears that we should ensure that the clipping path is reset when the restore (`Q`) operator is encountered.

Fixes 6413.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2015

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f07b242abe1505d/output.txt

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2015

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/3d8729338879aa8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2015

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/bcd18a2e8ccbd2b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2015

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/3d8729338879aa8/output.txt

Total script time: 19.05 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2015

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/bcd18a2e8ccbd2b/output.txt

Total script time: 19.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2015

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/2912092bca621bc/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2015

From: Bot.io (Linux)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5fc9d700175e376/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2015

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/5fc9d700175e376/output.txt

Total script time: 19.44 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2015

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/2912092bca621bc/output.txt

Total script time: 19.53 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

timvandermeij added a commit that referenced this pull request Sep 4, 2015
Ensure that the clipping path is reset when the state is restored (issue 6413)
@timvandermeij timvandermeij merged commit 2a0e078 into mozilla:master Sep 4, 2015
@timvandermeij
Copy link
Contributor

Nice work!

@Snuffleupagus Snuffleupagus deleted the issue-6413 branch September 4, 2015 15:58
@nbenitez
Copy link

nbenitez commented Mar 9, 2024

Spec link is broken, here it's an updated one:
https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf#G7.3882161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF is missing content
4 participants