Only choose a (3, 1) cmap table for TrueType fonts that have an encoding specified (issue 6410) #6425
Conversation
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/cdb5da75e94a0ba/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/cdb5da75e94a0ba/output.txt Total script time: 0.64 mins Published |
…ing specified (issue 6410) For (1, 0) cmaps, we have two different codepaths depending on whether the font has/hasn't got an encoding. But with (3, 1) cmaps we don't have a good fallback when the encoding is missing, hence this patch changes `readCmapTable` to only choose a (3, 1) cmap table if the font is non-symbolic *and* an encoding exists. Without this, we'll not be able to successfully create a working glyph map for some TrueType fonts with (3, 1) cmap tables. Fixes 6410.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/5e467728a5f3780/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/4133c307222e84c/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/4133c307222e84c/output.txt Total script time: 19.07 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5e467728a5f3780/output.txt Total script time: 19.50 mins
|
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/d7c154c21b843dc/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/266a8b6f4a1667d/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/d7c154c21b843dc/output.txt Total script time: 18.22 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/266a8b6f4a1667d/output.txt Total script time: 19.55 mins
|
Only choose a (3, 1) cmap table for TrueType fonts that have an encoding specified (issue 6410)
For (1, 0) cmaps, we have two different codepaths depending on whether the font has/hasn't got an encoding. But with (3, 1) cmaps we don't have a good fallback when the encoding is missing, hence this patch changes
readCmapTableto only choose a (3, 1) cmap table if the font is non-symbolic and an encoding exists. Without this, we'll not be able to successfully create a working glyph map for some TrueType fonts with (3, 1) cmap tables.Fixes #6410.
Please note: I'm waiting to hear back from the issue reporter if it's OK for us to use the PDF file as a test-case, since I'd prefer not having to create (yet another) reduced test-case.r? @brendandahl