Don't clear the canvas until re-rendering is finished when the scale or rotation is changed (issue 6467)
#6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le` or `rotation` is changed (issue 6467) *This regressed in PR 4920.* The main motivation for PR 4920 was to quickly get rid of old canvases when pages are evicted from the `PDFPageViewBuffer` cache. However it inadvertently broke the use-case where the `canvas` is used as a preview, on scale or rotation changes, until the re-rendering is finished. Fixes 6467.
brendandahl
added a commit
that referenced
this pull request
Sep 29, 2015
Don't clear the `canvas` until re-rendering is finished when the `scale` or `rotation` is changed (issue 6467)
|
Thanks for the quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed in PR #4920.
The main motivation for PR #4920 was to quickly get rid of old canvases when pages are evicted from the
PDFPageViewBuffercache. However it inadvertently broke the use-case where thecanvasis used as a preview, on scale or rotation changes, until the re-rendering is finished.Fixes #6467.
r? @brendandahl
Please note: The second commit is not related to the issue, but it fixes a couple of stylistic issues that I saw while working on this code; easier reviewing with: 424f62e?w=1.