Better CSS scaling for deviceRixelRatio != 1. #6552
Conversation
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ddc5b10bb18b785/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/ddc5b10bb18b785/output.txt Total script time: 0.63 mins Published |
yurydelendik
force-pushed
the
dpiscale
branch
from
3963c93 to
0d8fcd3
Compare
yurydelendik
changed the title
|
I see a positive response to this patch on the Bugzilla issue. Perhaps @brendandahl can review this patch? |
|
The patch is trivial (simple math) -- open for feedback from community, especially Windows users with various scallings set. |
|
This is how it looks for me on Windows 10 x64. Left is the current master, right is this patch. The right side is definitely sharper and the left side is more blurry (click to enlarge).
|
| @@ -238,6 +238,55 @@ function binarySearchFirstItem(items, condition) { | |||
| } | |||
|
|
|||
| /** | |||
| * Approximates float number as a fraction using Farley sequence (max order | |||
There was a problem hiding this comment.
Don't you mean the Farey sequence (without an "l")?
There was a problem hiding this comment.
Fixed, thanks.
yurydelendik
force-pushed
the
dpiscale
branch
from
0d8fcd3 to
7cb3275
Compare
Better CSS scaling for deviceRixelRatio != 1.
|
Thank you! |
There are some devices with devicePixelRatio that is equal to 3, 1.5 or sometimes 1.25 (e.g. Windows medium font). Trying harder to better fit native canvas pixels into CSS layout, e.g. for devicePixelRatio==1.25, it will try to create canvas which physical width divisible by 5 and CSS width divisible by 4, hoping that during composition the pixels lay perfectly on screens physical pixels.