Find match count (rebase of #5051) #6580
Conversation
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/7c8502f8126921d/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/7c8502f8126921d/output.txt Total script time: 1.13 mins Published |
| @@ -386,6 +395,15 @@ var PDFFindController = (function PDFFindControllerClosure() { | |||
| } | |||
| }, | |||
|
|
|||
| updateUIResultCount: | |||
| function PDFFindController_updateUICountMatches() { | |||
There was a problem hiding this comment.
Nit: The function in pdf_find_bar.js is called updateResultsCount, so for consistency we might want to add an "s" to the current method name, i.e. updateUIResultsCount instead!?.
(Also, the name after function isn't entirely consistent.)
|
r=me, with nit addressed. |
Find match count (rebase of #5051)
|
Is it feasible to add an index to the counter, e.g. "1 out of 1"? And also, a tooltip that shows what the number means when hovering over the number may be helpful. |
|
Could you open a separate issue for that and label it as a feature? |
Bases of #5051
Fixes #4805