-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new indeterminate loading bar animation for the default viewer #6586
Create a new indeterminate loading bar animation for the default viewer #6586
Conversation
This is a much more elegant solution (in terms of code) and I think it also looks better than before! @yurydelendik @brendandahl What do you think? |
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/cd888810485d46e/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/cd888810485d46e/output.txt Total script time: 0.77 mins Published |
r=me. Can you adjust gradient to not have sharp edges (add few pixels of color transition)? |
Sure; does the new preview look better? /botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/2dc29c9b3871cba/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/2dc29c9b3871cba/output.txt Total script time: 1.21 mins Published |
lgtm |
This patch contains an alternative solution (see the referenced PRs in 4718), in order for the indeterminate loading bar to have a consistent speed regardless of width. Fixes 4718.
…-bar Create a new indeterminate loading bar animation for the default viewer
@yurydelendik Thanks for reviewing the patch! |
This patch contains an alternative solution (see the referenced PRs in #4718), in order for the indeterminate loading bar to have a consistent speed regardless of width.
Fixes #4718.