Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new indeterminate loading bar animation for the default viewer #6586

Merged
merged 1 commit into from
Nov 4, 2015
Merged

Create a new indeterminate loading bar animation for the default viewer #6586

merged 1 commit into from
Nov 4, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

This patch contains an alternative solution (see the referenced PRs in #4718), in order for the indeterminate loading bar to have a consistent speed regardless of width.

Fixes #4718.

@timvandermeij
Copy link
Contributor

This is a much more elegant solution (in terms of code) and I think it also looks better than before!

@yurydelendik @brendandahl What do you think?

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Nov 4, 2015

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/cd888810485d46e/output.txt

@yurydelendik
Copy link
Contributor

r=me.

Can you adjust gradient to not have sharp edges (add few pixels of color transition)?

@Snuffleupagus
Copy link
Collaborator Author

Can you adjust gradient to not have sharp edges (add few pixels of color transition)?

Sure; does the new preview look better?

/botio-windows preview

@pdfjsbot
Copy link

pdfjsbot commented Nov 4, 2015

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/2dc29c9b3871cba/output.txt

@yurydelendik
Copy link
Contributor

lgtm

This patch contains an alternative solution (see the referenced PRs in 4718), in order for the indeterminate loading bar to have a consistent speed regardless of width.

Fixes 4718.
Snuffleupagus added a commit that referenced this pull request Nov 4, 2015
…-bar

Create a new indeterminate loading bar animation for the default viewer
@Snuffleupagus Snuffleupagus merged commit c05416f into mozilla:master Nov 4, 2015
@Snuffleupagus
Copy link
Collaborator Author

@yurydelendik Thanks for reviewing the patch!

@Snuffleupagus Snuffleupagus deleted the new-indeterminate-loading-bar branch November 4, 2015 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants