-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes incorrect PDF file font metrics. #6601
Conversation
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/8c4d3708d8d1449/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/1f09af14d8372b8/output.txt |
This also seems to fix #4665, nicely done! |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/1f09af14d8372b8/output.txt Total script time: 18.79 mins
Image differences available at: http://107.22.172.223:8877/1f09af14d8372b8/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/8c4d3708d8d1449/output.txt Total script time: 19.64 mins
Image differences available at: http://107.21.233.14:8877/8c4d3708d8d1449/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/4d43a9096460882/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3c9015bddc28ae8/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3c9015bddc28ae8/output.txt Total script time: 19.42 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/4d43a9096460882/output.txt Total script time: 19.99 mins
|
Assuming that intent of makeref was to land the patch, merging... thanks |
Fixes incorrect PDF file font metrics.
Can you please pull #7046 as well ? This is a small fix to handle the overrides when descent/yMin is zero. Thanks |
The PDF lies about font metrics in font descriptors, e.g. PDF file from #4339 http://www.nasa.gov/pdf/750614main_NASA_FY_2014_Budget_Estimates-508.pdf . It's noticeable in the text layer.
Font HJMTJJ+TimesNewRoman report in PDF Ascent=1026/1000 and Descent=-307/1000, but the font hhea Ascent=1638/2048 and Descent = -410/2048.