Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[api-minor] Moving text layer rendering into src/display and better "text" testing. #6619

Merged
merged 3 commits into from
Nov 19, 2015
Merged

[api-minor] Moving text layer rendering into src/display and better "text" testing. #6619

merged 3 commits into from
Nov 19, 2015

Conversation

yurydelendik
Copy link
Contributor

Combines page rendering and text layer in the "text" tests.

(thuluthfont-text test was removed due to invalid unicode characters in the text nodes)

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/649d19833793092/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/9e403db26e68f06/output.txt

@yurydelendik yurydelendik changed the title Moving text layer rendering into src/display and better "text" testing. [api-minor] Moving text layer rendering into src/display and better "text" testing. Nov 10, 2015
@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://107.22.172.223:8877/9e403db26e68f06/output.txt

Total script time: 19.57 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/9e403db26e68f06/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux)

Failed

Full output at http://107.21.233.14:8877/649d19833793092/output.txt

Total script time: 19.89 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/649d19833793092/reftest-analyzer.html#web=eq.log

Rob--W
Rob--W reviewed Nov 10, 2015
View reviewed changes
test/text_layer_test.css
background-color: rgba(255, 255, 32, 0.1);
-webkit-box-sizing:border-box;
-moz-box-sizing:border-box;
box-sizing:border-box;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add space after :, 3x.

@yurydelendik
Copy link
Contributor Author

Made #textLayer=visible match to new "text" test output.

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/190c29bd5e1335b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/190c29bd5e1335b/output.txt

Total script time: 0.74 mins

Published

@timvandermeij
Copy link
Contributor

I would say that this fixes #4576.

@yurydelendik yurydelendik mentioned this pull request Nov 11, 2015
Closed
@timvandermeij
Copy link
Contributor

@yurydelendik Could you rebase this PR?

brendandahl added a commit that referenced this pull request Nov 19, 2015
@brendandahl
Merge pull request #6619 from yurydelendik/mv-textlayer
fc2d7e8 
[api-minor] Moving text layer rendering into src/display and better "text" testing.
@brendandahl brendandahl merged commit fc2d7e8 into mozilla:master Nov 19, 2015
@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_makeref from @brendandahl received. Current queue size: 1

Live output at: http://107.21.233.14:8877/53d7358c3d978a9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @brendandahl received. Current queue size: 1

Live output at: http://107.22.172.223:8877/4fac33e392a185a/output.txt

@timvandermeij timvandermeij mentioned this pull request Nov 19, 2015
Closed
@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/4fac33e392a185a/output.txt

Total script time: 18.57 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/53d7358c3d978a9/output.txt

Total script time: 19.42 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus mentioned this pull request Nov 21, 2015
Merged
@timvandermeij timvandermeij mentioned this pull request Nov 22, 2015
Closed
@yurydelendik yurydelendik deleted the mv-textlayer branch January 28, 2016 21:06
@Snuffleupagus Snuffleupagus mentioned this pull request Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandahl brendandahl

Labels
core test text-selection viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yurydelendik @pdfjsbot @timvandermeij @brendandahl @Rob--W