Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the data.annotationFlags parameter for annotations (PR 6672 follow-up) #6677

Merged
merged 1 commit into from
Nov 23, 2015
Merged

Restore the data.annotationFlags parameter for annotations (PR 6672 follow-up) #6677

merged 1 commit into from
Nov 23, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #6672 (comment).

I don't think data.annotationFlags should have been removed, but unfortunately I missed it while reviewing the patch, sorry about that!

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5988778220f6fe6/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/86a061dced3cf14/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/f34ca089609d9d5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/f34ca089609d9d5/output.txt

Total script time: 18.54 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/86a061dced3cf14/output.txt

Total script time: 19.78 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

timvandermeij added a commit that referenced this pull request Nov 23, 2015
Restore the `data.annotationFlags` parameter for annotations (PR 6672 follow-up)
@timvandermeij timvandermeij merged commit dcd2812 into mozilla:master Nov 23, 2015
@timvandermeij
Copy link
Contributor

Thanks! I'll file a new issue to refactor this data passing as it seems unnecessary and error-prone to me.

@Snuffleupagus Snuffleupagus deleted the restore-data-annotationFlags branch November 23, 2015 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants