[api-minor] Replaces UnsupportedManager with callback. #6698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,7 @@ | |||
| /* globals IDENTITY_MATRIX, FONT_IDENTITY_MATRIX, TextRenderingMode, ImageData, | |||
| ImageKind, PDFJS, Uint32ArrayView, error, WebGLUtils, OPS, warn, | |||
| shadow, isNum, Util, TilingPattern, getShadingPatternFromIR, isArray, | |||
| info, assert, UnsupportedManager, UNSUPPORTED_FEATURES */ | |||
| info, assert, UNSUPPORTED_FEATURES */ | |||
There was a problem hiding this comment.
The UNSUPPORTED_FEATURES global is now also unused and can be removed.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a633f6163bd207a/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a633f6163bd207a/output.txt Total script time: 0.77 mins Published |
I don't think we shall show a warning bar in this case, we know how to workaround those bad cases and we can resume properly. However, we might trigger that bar for cases, e.g. when fonts are corrupted, but in this case we know the reason. |
|
TODO:
|
yurydelendik
force-pushed
the
rm-UnsupportedManager
branch
from
55c50f6 to
c9cb6a3
Compare
brendandahl
added a commit
that referenced
this pull request
Dec 2, 2015
[api-minor] Replaces UnsupportedManager with callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnsupportedManager is only global variable we are using and blocks SharedWorker refactoring. This PR deprecated this API and (temporary?) replaces with PDFDocumentLoadingTask callback.
I don't think we need to use it at the error() function -- we need to pass or exception to the UI via promises, or handle them in the evaluator and send UnsupportedFeature message if needed.