Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the superfluous PDFJS.disableFontFace = false; statement at the top of font_loader.js (issue 6742) #6747

Merged
merged 1 commit into from
Dec 12, 2015
Merged

Remove the superfluous PDFJS.disableFontFace = false; statement at the top of font_loader.js (issue 6742) #6747

merged 1 commit into from
Dec 12, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #6742.

@Snuffleupagus
Remove the superfluous PDFJS.disableFontFace = false; statement at …
1206849 
…the top of font_loader.js (issue 6742)

Fixes 6742.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/38bd04de24755d4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5afd2181b9de1a6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/38bd04de24755d4/output.txt

Total script time: 19.75 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/5afd2181b9de1a6/output.txt

Total script time: 20.15 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

Looks good to me, though I also really wonder why it was there in the first place if it is an API option...

@Snuffleupagus
Copy link
Collaborator Author

Looks good to me, though I also really wonder why it was there in the first place if it is an API option...

Probably for "historical reasons", please see #6742 (comment) for some background.

yurydelendik added a commit that referenced this pull request Dec 12, 2015
@yurydelendik
Merge pull request #6747 from Snuffleupagus/issue-6742
f7ec866 
Remove the superfluous `PDFJS.disableFontFace = false;` statement at the top of font_loader.js (issue 6742)
@yurydelendik yurydelendik merged commit f7ec866 into mozilla:master Dec 12, 2015
@yurydelendik
Copy link
Contributor

Thank you

@Snuffleupagus Snuffleupagus deleted the issue-6742 branch December 12, 2015 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Snuffleupagus @pdfjsbot @timvandermeij @yurydelendik