Only export Uint32ArrayView when it's actually defined, to prevent breaking e.g. the Firefox addon/built-in version
#6762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…breaking e.g. the Firefox addon/built-in version *This is a follow-up to PR 6683.*
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/15c6fd46f8c104d/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/15c6fd46f8c104d/output.txt Total script time: 0.79 mins Published |
|
Given that: this is a very recent regression, the Firefox development addon is currently completely unusable without this patch, and finally considering the simplicity of the patch; I'm merging this with r=me. |
Snuffleupagus
added a commit
that referenced
this pull request
Dec 16, 2015
Only export `Uint32ArrayView` when it's actually defined, to prevent breaking e.g. the Firefox addon/built-in version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #6683.
The Firefox addon fails with
ReferenceError: Uint32ArrayView is not defined.