Remove unused variables #6765
Remove unused variables #6765
Conversation
| @@ -12,7 +12,7 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| /* globals PDFJS, Promise */ | |||
| /* globals Promise */ | |||
There was a problem hiding this comment.
Thanks to https://github.com/mozilla/pdf.js/blob/master/.jshintrc#L7, you should also be able to remove Promise here (might apply elsewhere too).
There was a problem hiding this comment.
Done in the new commit for all occurrences I could find.
timvandermeij
force-pushed
the
unused
branch
from
35173ff to
155c054
Compare
timvandermeij
force-pushed
the
unused
branch
from
155c054 to
df81b83
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/8bd8408042822d8/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/8bd8408042822d8/output.txt Total script time: 0.78 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/399babe669d0edf/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/e6d6405eec3c46d/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/399babe669d0edf/output.txt Total script time: 20.08 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/e6d6405eec3c46d/output.txt Total script time: 20.24 mins
|
|
Looks good, thank you. |
Found by enabling JSHint's
unusedoption temporarily after the UMD patch landed and manually inspecting its results. The option is not nearly ready to be enabled by default because of many false positives, but it did find some interesting things that this PR addresses.Furthermore:
readUint16which might change the stream and thus its behavior.