-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not modify data.rect
in AnnotationElement_createContainer
, since that will corrupt the annotation position on subsequent calls
#6805
Conversation
…ce that will corrupt the annotation position on subsequent calls Fixes 6804; this regressed in PR 6714.
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c48beba8870b747/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c48beba8870b747/output.txt Total script time: 0.84 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/37f51d0af1f1fd4/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1b737d7789cdfde/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/37f51d0af1f1fd4/output.txt Total script time: 20.52 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/1b737d7789cdfde/output.txt Total script time: 20.74 mins
|
Do not modify `data.rect` in `AnnotationElement_createContainer`, since that will corrupt the annotation position on subsequent calls
Thank you for fixing this so quickly! |
Fixes #6804; this regressed in PR #6714.
I'm not yet sure how we're going to test this, but I'm looking into it right now.
Edit: I've not been able to find a way to test this, so I'm thinking that we can do without a test for now, given that the patch fixes a recent regression.