Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not modify data.rect in AnnotationElement_createContainer, since that will corrupt the annotation position on subsequent calls #6805

Merged
merged 1 commit into from
Dec 27, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #6804; this regressed in PR #6714.

I'm not yet sure how we're going to test this, but I'm looking into it right now.
Edit: I've not been able to find a way to test this, so I'm thinking that we can do without a test for now, given that the patch fixes a recent regression.

…ce that will corrupt the annotation position on subsequent calls

Fixes 6804; this regressed in PR 6714.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c48beba8870b747/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/37f51d0af1f1fd4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/1b737d7789cdfde/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/37f51d0af1f1fd4/output.txt

Total script time: 20.52 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/1b737d7789cdfde/output.txt

Total script time: 20.74 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

timvandermeij added a commit that referenced this pull request Dec 27, 2015
Do not modify `data.rect` in `AnnotationElement_createContainer`, since that will corrupt the annotation position on subsequent calls
@timvandermeij timvandermeij merged commit ad4354c into mozilla:master Dec 27, 2015
@timvandermeij
Copy link
Contributor

Thank you for fixing this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotations misplaced after reload
3 participants