-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for Squiggly annotations #6823
Implement support for Squiggly annotations #6823
Conversation
@@ -73,6 +73,10 @@ | |||
cursor: pointer; | |||
} | |||
|
|||
.annotationLayer .squigglyAnnotation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the rules are identical, can't you just do this instead:
.annotationLayer .underlineAnnotation,
.annotationLayer .squigglyAnnotation,
.annotationLayer .strikeoutAnnotation {
cursor: pointer;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Done in the new commit.
r=me, with less duplication in the CSS. |
3bc3548
to
34918a6
Compare
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/0afca4fc0b07b39/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/0afca4fc0b07b39/output.txt Total script time: 0.80 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/7a3daebd4fda79a/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c0e47c72f3cc0ce/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/7a3daebd4fda79a/output.txt Total script time: 20.46 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c0e47c72f3cc0ce/output.txt Total script time: 21.12 mins
|
Landing with r=Snuffleupagus and r=me. /botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e2e06a53b64261b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3651ae0105f3db7/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3651ae0105f3db7/output.txt Total script time: 20.51 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e2e06a53b64261b/output.txt Total script time: 20.98 mins
|
Implement support for Squiggly annotations
Notice that the reduced test case provided with this patch now renders just like Adobe Reader/Acrobat and without any warnings in the console.