Always display deprecated messages, regardless of the verbosity setting
#6921
Conversation
…ting Currently the `deprecated` message is using `warn`, meaning that it's possible to disable warnings about deprecated API usage through the `PDFJS.verbosity` setting. I don't think that it should be possible to opt out of deprecation messages,[1] since it might mean that in a custom deployment of PDF.js these messages could be overlooked, leading to PDF.js being broken (seemingly without any warning) when updating to a future version. Obviously this could be considered the responsibility of the people doing custom PDF.js implementations, but in order to reduce the support burden later on, it seems better to "annoy" people upfront. Compared to various `info`/`warn`/`error` messages, `deprecated` messages should be very simple to get rid of -- just update the API usage and the message goes away! --- [1] In e.g. Firefox it doesn't seem possible to prevent deprecation warnings from being displayed (in the Browser Console).
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/36e015e02515771/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/36e015e02515771/output.txt Total script time: 1.13 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/abb39983153d554/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a2ceb38a81097c9/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/a2ceb38a81097c9/output.txt Total script time: 20.40 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/abb39983153d554/output.txt Total script time: 21.18 mins
|
|
Thanks! (Merging with r=me and http://logs.glob.uno/?c=mozilla%23pdfjs&s=28+Jan+2016&e=28+Jan+2016#c45489) |
Always display `deprecated` messages, regardless of the verbosity setting
Currently the
deprecatedmessage is usingwarn, meaning that it's possible to disable warnings about deprecated API usage through thePDFJS.verbositysetting.I don't think that it should be possible to opt out of deprecation messages,[1] since it might mean that in a custom deployment of PDF.js these messages could be overlooked, leading to PDF.js being broken (seemingly without any warning) when updating to a future version.
Obviously this could be considered the responsibility of the people doing custom PDF.js implementations, but in order to reduce the support burden later on, it seems better to "annoy" people upfront.
Compared to various
info/warn/errormessages,deprecatedmessages should be very simple to get rid of -- just update the API usage and the message goes away![1] In e.g. Firefox it doesn't seem possible to prevent deprecation warnings from being displayed (in the Browser Console).