Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Always expose data.title and data.contents for TextAnnotation #7009

Merged
merged 1 commit into from
Feb 22, 2016

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Feb 19, 2016

Any reason to not set title and contents when the annotation has popup?

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/40d137ce8dab86e/output.txt

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/7a3eac783c42be4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/5446ad354d85ca1/output.txt

@yurydelendik
Copy link
Contributor

/botio-linux lint

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_lint from @yurydelendik received. Current queue size: 1

Live output at: http://107.21.233.14:8877/fa646932b29dd6f/output.txt

@timvandermeij timvandermeij changed the title always expose data.title and data.contents for TextAnnotation [api-minor] Always expose data.title and data.contents for TextAnnotation Feb 22, 2016
@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/5446ad354d85ca1/output.txt

Total script time: 21.79 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://107.22.172.223:8877/7a3eac783c42be4/output.txt

Total script time: 21.85 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.22.172.223:8877/7a3eac783c42be4/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/fa646932b29dd6f/output.txt

Total script time: 0.96 mins

  • Lint: Passed

@timvandermeij
Copy link
Contributor

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/f0ebf17c3939e68/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/f0ebf17c3939e68/output.txt

Total script time: 20.12 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

timvandermeij added a commit that referenced this pull request Feb 22, 2016
[api-minor] Always expose data.title and data.contents for TextAnnotation
@timvandermeij timvandermeij merged commit c53581f into mozilla:master Feb 22, 2016
@timvandermeij
Copy link
Contributor

Thank you for your contribution!

@xlc xlc deleted the annotations-fix branch February 22, 2016 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants