Group popup creation code and apply it to more annotation types #7016
Conversation
|
Maybe Highlight/Underline/Squiggly/StrikeOut annotations should have a common base class? Identical code over four classes is not ideal. |
|
Now that you brought this up, there are more types that have popups (almost all actually), so I'll update the patch to move most popup handling to the AnnotationElement base class. Thank you! |
timvandermeij
force-pushed
the
annotations-missing-popup
branch
5 times, most recently
from
295a15c to
3cd0731
Compare
timvandermeij
changed the title
|
|
||
| this.data.hasPopup = dict.has('Popup'); | ||
| this.data.title = stringToPDFString(dict.get('T') || ''); | ||
| this.data.contents = stringToPDFString(dict.get('Contents') || ''); |
There was a problem hiding this comment.
So, it appears that this code is repeated six times throughout the file. Would it be possible to re-factor into a helper function instead (similar to the other file)?
There was a problem hiding this comment.
Yes, I've done that in the new commit.
timvandermeij
force-pushed
the
annotations-missing-popup
branch
2 times, most recently
from
3f617a4 to
c7e61e3
Compare
| this.data.hasPopup = dict.has('Popup'); | ||
| this.data.title = stringToPDFString(dict.get('T') || ''); | ||
| this.data.contents = stringToPDFString(dict.get('Contents') || ''); | ||
| this._preparePopup(dict); |
There was a problem hiding this comment.
Nit: I think that you can now remove the variable and simply use parameters.dict here.
There was a problem hiding this comment.
Done in the new commit.
timvandermeij
force-pushed
the
annotations-missing-popup
branch
from
c7e61e3 to
ad31e52
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ff467292ebce8cc/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/ff467292ebce8cc/output.txt Total script time: 0.88 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/ca5bc4ff931c980/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d7bcd5ad30b9474/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/ca5bc4ff931c980/output.txt Total script time: 20.24 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/d7bcd5ad30b9474/output.txt Total script time: 21.79 mins
|
|
Looks good, and much better with the helper methods added, thank you for the patch! /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/11da4056ff46ac2/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/bd0b7a4f9f19e24/output.txt |
Group popup creation code and apply it to more annotation types
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/11da4056ff46ac2/output.txt Total script time: 20.09 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/bd0b7a4f9f19e24/output.txt Total script time: 21.18 mins
|
Fixes #7014.