Extract CFFParser and Type1Parser from fonts.js

[Snuffleupagus]

Re: #6777.

I've tried to come up with a solution to the SEAC_ANALYSIS_ENABLED mess in the font_spec.js tests.

Unfortunately GitHub chokes on the diff sizes, but I'm not sure how to divide the first patch into smaller chunks unless we put various CFF... classes into separate files!?
Edit: Perhaps it would help if CFFCompiler is separate, but I'm not sure that would be enough to fit within the limits (https://help.github.com/articles/what-are-the-limits-for-viewing-content-and-diffs-in-my-repository/#diff-limits).

---

This change is

[yurydelendik]

Can you add extra commit with asserts or if/throw to check seacAnalysisEnabled !== undefined in the CFFParser and Type1Parser? We will remove that after at least one testing was run.

---

Reviewed 2 of 5 files at r1, 4 of 4 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

src/core/type1_parser.js, line 98 [r2] (raw file):
make seacAnalysisEnabled as argument of convert

---

Comments from the review on Reviewable.io

[Snuffleupagus]

Done, and thanks for the review comments both here and on IRC!

---

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

src/core/type1_parser.js, line 98 [r2] (raw file):
Done.

---

Comments from the review on Reviewable.io

[Snuffleupagus]

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/f00bcba04f035de/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/58f74f1e97e1c97/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/f00bcba04f035de/output.txt

Total script time: 20.00 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/58f74f1e97e1c97/output.txt

Total script time: 22.05 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[yurydelendik]

(asserts can be removed)

[Snuffleupagus]

The asserts were removed.

/botio test

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/dce2b02a7886fa5/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/0da43e60c174590/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/dce2b02a7886fa5/output.txt

Total script time: 20.48 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/0da43e60c174590/output.txt

Total script time: 22.00 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[yurydelendik]

Thank you for the patch.