Removing "entry-loader" dependency from webpack. #7189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch does not affect functionality of the core library or generic/addon viewers, and trivial change in the src/frameworks.js . (However it fixes regression introduced by browser section in the package.json file, see #7150) r=me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7165
Basically webpack and browserify users are now responsible for making pdf.worker.js bundle. They can use pdfjs-dist/build/pdf.worker.entry file as entry point for that.
Ugly 'entry?name=[hash]-worker.js!./pdf.worker.js' is gone, but it can be used in PDFJS.workerSrc context in the main file. Webpack will generate one additional bundle for main one -- it's loaded for disableWorker mode (aka IE9 compat).