-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove combineUrl
and replace it with new URL
. Issue #7183, for reference.
#7197
Remove combineUrl
and replace it with new URL
. Issue #7183, for reference.
#7197
Conversation
var pdfUrl = combineUrl(window.location.href, | ||
'../pdfs/annotation-fileattachment.pdf'); | ||
var pdfUrl = new URL('../pdfs/annotation-fileattachment.pdf', | ||
window.location).href; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: please reduce the indentation with one space, so that it's lined up like this:
var pdfUrl = new URL('../pdfs/annotation-fileattachment.pdf',
window.location).href;
Please update the commit message, and the PR title, to something more descriptive than just
|
combineUrl
and replace it with new URL
. Issue #7183, for reference.
6833896
to
5793064
Compare
Hi, Have corrected the indentation and committed. Also modified the PR Title and commit messages appropriately. Please review. Thank you for your comments. |
Could you squash commits into one? |
5793064
to
a25c29d
Compare
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/3161bfff09399a0/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/656a5da1632c6a6/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/3161bfff09399a0/output.txt Total script time: 20.50 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/656a5da1632c6a6/output.txt Total script time: 22.55 mins
|
Thank you for your contribution! |
Thank you all for your guidance and the opportunity. |
changes made to replace 'combineUrl' references to 'new URL' and also removed combineUrl utility function.
Fixes #7183