Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove combineUrl and replace it with new URL. Issue #7183, for reference. #7197

Merged

Conversation

prakashpalanisamy
Copy link
Contributor

@prakashpalanisamy prakashpalanisamy commented Apr 15, 2016

changes made to replace 'combineUrl' references to 'new URL' and also removed combineUrl utility function.

Fixes #7183

var pdfUrl = combineUrl(window.location.href,
'../pdfs/annotation-fileattachment.pdf');
var pdfUrl = new URL('../pdfs/annotation-fileattachment.pdf',
window.location).href;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please reduce the indentation with one space, so that it's lined up like this:

      var pdfUrl = new URL('../pdfs/annotation-fileattachment.pdf', 
                           window.location).href;

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Apr 15, 2016

Please update the commit message, and the PR title, to something more descriptive than just changes for the issue #7183, since it's not really possible to tell what the patch does without looking at the code. For example, something like this:

Remove `combineUrl` and replace it with `new URL`

@prakashpalanisamy prakashpalanisamy changed the title changes for the issue #7183. Remove combineUrl and replace it with new URL. Issue #7183, for reference. Apr 15, 2016
@prakashpalanisamy
Copy link
Contributor Author

Hi, Have corrected the indentation and committed. Also modified the PR Title and commit messages appropriately. Please review. Thank you for your comments.

@yurydelendik
Copy link
Contributor

Could you squash commits into one?

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/3161bfff09399a0/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/656a5da1632c6a6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/3161bfff09399a0/output.txt

Total script time: 20.50 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/656a5da1632c6a6/output.txt

Total script time: 22.55 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 4a601ff into mozilla:master Apr 15, 2016
@timvandermeij
Copy link
Contributor

Thank you for your contribution!

@prakashpalanisamy
Copy link
Contributor Author

Thank you all for your guidance and the opportunity.

@prakashpalanisamy prakashpalanisamy deleted the remove-combineurl-test branch April 16, 2016 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants