[Bug 1194700] Ensure that the customScaleOption is hidden in e10s
#7242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Firefox is run in e10s mode, which will soon be the default, the PDF.js zoom dropdown menu doesn't look right. This is apparently because the `<select>` DOM element is rendered in the parent, and that all the necessary style information isn't sent up from the child. See the discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=910022. Besides this causing the PDF.js UI to *look* worse in e10s, notably it also means that the `customScaleOption` isn't hidden like it ought to be. To work-around that, this patch utilizes the `hidden` attribute, since https://bugzilla.mozilla.org/show_bug.cgi?id=1242450 at least made that work in e10s. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1194700.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/3621d533ace11c6/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/3621d533ace11c6/output.txt Total script time: 1.02 mins Published |
|
Given that https://bugzilla.mozilla.org/show_bug.cgi?id=910022 affects the visual appearance of the PDF Viewer that is shipped in e10s Firefox, we might be able to use that to get the bug re-prioritized!? |
|
Thank you for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Firefox is run in e10s mode, which will soon be the default, the PDF.js zoom dropdown menu doesn't look right. This is apparently because the
<select>DOM element is rendered in the parent, and that all the necessary style information isn't sent up from the child. See the discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=910022.Besides this causing the PDF.js UI to look worse in e10s, notably it also means that the
customScaleOptionisn't hidden like it ought to be.To work-around that, this patch utilizes the
hiddenattribute, since https://bugzilla.mozilla.org/show_bug.cgi?id=1242450 at least made that work in e10s.Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1194700.