-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves all testing into gulpfile. #7260
Conversation
4e3d5c6
to
40f8e7c
Compare
There appears to be an issue on the Windows bot with this patch regarding output buffering. The lint command fails directly without even trying and the unittest/test commands show no output in the logs until everything is done. Any idea what is causing this? |
40f8e7c
to
30ae96e
Compare
I'm thinking we had this issue before. Trying to fix. |
30ae96e
to
376b6bb
Compare
installing newer node.js on botio fixed the issue |
@@ -18,16 +18,19 @@ | |||
'use strict'; | |||
|
|||
var fs = require('fs'); | |||
var path = require('path'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable appears to be unused, so we should be able to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
/botio lint |
From: Bot.io (Linux)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ad2db1cab51da04/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/cce63fab52ccfcf/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/ad2db1cab51da04/output.txt Total script time: 1.18 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/cce63fab52ccfcf/output.txt Total script time: 2.04 mins
|
/botio unittest |
From: Bot.io (Linux)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 1 Live output at: http://107.21.233.14:8877/fe96086ec3ca0d0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 1 Live output at: http://107.22.172.223:8877/cf40dbebe6a3f7b/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/fe96086ec3ca0d0/output.txt Total script time: 1.74 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/cf40dbebe6a3f7b/output.txt Total script time: 1.77 mins
|
/botio preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/15759cda0b975bf/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/95ed8435076f3c8/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/15759cda0b975bf/output.txt Total script time: 1.12 mins Published |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/95ed8435076f3c8/output.txt Total script time: 1.48 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/782762232bfaaf6/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/8ffe8d0a68f7b0b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/782762232bfaaf6/output.txt Total script time: 21.47 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/8ffe8d0a68f7b0b/output.txt Total script time: 27.38 mins
|
Nice work, thanks! |
No description provided.