Removes circular dependency of secondary toolbar on app.js. #7266
Conversation
| } | ||
| var appConfig = PDFViewerApplication.appConfig; | ||
| if (PDFViewerApplication.pdfViewer.containsElement(evt.target) || | ||
| (appConfig.toolbar.container.contains(evt.target) && |
There was a problem hiding this comment.
This is changing the current behaviour, was that indended?
Are you perhaps trying to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1211884 here as well?
There was a problem hiding this comment.
It goes along with changing event handles of toolbar icons to just call eventBus.dispatch (before they called secondary's handlers which were closing itself).
However, change ,false) => ,true) below might fix 1211884
|
Should we change these lines as well: https://github.com/yurydelendik/pdf.js/blob/secondary/web/app.js#L281-L288? Perhaps something like this: { element: appConfig.fullscreen.contextFirstPage,
handler: webViewerFirstPage },
{ element: appConfig.fullscreen.contextLastPage,
handler: webViewerLastPage },
{ element: appConfig.fullscreen.contextPageRotateCw,
handler: webViewerRotateCw },
{ element: appConfig.fullscreen.contextPageRotateCcw,
handler: webViewerRotateCcw } |
The menu items shall generate eventBus commands -- changed the code to do just that. |
|
This line can be removed now too: https://github.com/mozilla/pdf.js/pull/7266/files#diff-529d1853ee1bba753a0fcb40ea778723L275. |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/9038ac11153e83f/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/9038ac11153e83f/output.txt Total script time: 1.06 mins Published |
|
Looks good, thank you! |
Fixes #7204