Prevent intermittent "Node was not found" errors when removing the zoomLayer in PDFPageView_draw
#7299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oomLayer` in `PDFPageView_draw` I've seen the above error occasionally when the scale is updated many times in quick succession, but I've not been able to pinpoint exactly why it happens. Since the error isn't caught, this means that the `pageViewDrawCallback` function doesn't run to completion. Unfortunately, given the very intermittent nature of the issue, I haven't got any good STR for reliably reproducing this issue. However, I hope that this patch can be accepted anyway, since it's simple and should help prevent unnecessary errors.
Snuffleupagus
changed the title
zoomLayer in PFPageView_drawzoomLayer in PDFPageView_draw
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/8f2fbfaa2e20099/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/8f2fbfaa2e20099/output.txt Total script time: 1.07 mins Published |
|
Thank you for the fix and the steps to reproduce! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen the above error occasionally when the scale is updated many times in quick succession, but I've not been able to pinpoint exactly why it happens.
Since the error isn't caught, this means that the
pageViewDrawCallbackfunction doesn't run to completion.Unfortunately, given the very intermittent nature of the issue, I haven't got any good STR for reliably reproducing this issue. However, I hope that this patch can be accepted anyway, since it's simple and should help prevent unnecessary errors.
Update:
For me, the following STR seems to hit this error quite often.
Update 2:
I've pushed a new version of the patch to fix a couple of stupid typos in the commit message.