Solving issue #7307, 'use strict' context in compatibility.js #7315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -591,3 +593,5 @@ if (typeof PDFJS === 'undefined') { | |||
| configurable: true | |||
| }); | |||
| })(); | |||
|
|
|||
| }).call((typeof window === 'undefined') ? this : window); | |||
There was a problem hiding this comment.
Nit: missing newline at the end of the file.
There was a problem hiding this comment.
Oh sorry, now it should be ok
McGiogen
force-pushed
the
bug-usestrict-compatibilityjs
branch
from
5ee8261 to
16d6eaf
Compare
| @@ -14,7 +14,9 @@ | |||
| */ | |||
| /* globals VBArray, PDFJS */ | |||
|
|
|||
| 'use strict'; | |||
| (function pdfjsWrapper() { | |||
| // Use strict in our context only - users might not want it | |||
There was a problem hiding this comment.
Can you remove (unimportant?) comment and rename pdfjsWrapper=>compatibilityWrapper? Looks good after that.
McGiogen
force-pushed
the
bug-usestrict-compatibilityjs
branch
from
4ce5f27 to
1c96cb8
Compare
|
Thank you for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added context to compatibility.js to have 'use strict' directive in our context only.
Solving "'Use strict' in pdfjs context only, compatibility.js #7307"