-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to prevent CanvasGraphics_getSinglePixelWidth
from intermittently returning incorrect values in Firefox (issue 7188)
#7330
Conversation
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c5338d3964eb8b2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/ae295ac51082085/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/ae295ac51082085/output.txt Total script time: 21.09 mins
Image differences available at: http://107.22.172.223:8877/ae295ac51082085/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/c5338d3964eb8b2/output.txt Total script time: 27.71 mins
Image differences available at: http://107.21.233.14:8877/c5338d3964eb8b2/reftest-analyzer.html#web=eq.log |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1f135d7bf70fcc5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/0d6d3ce3900d0ca/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/0d6d3ce3900d0ca/output.txt Total script time: 23.36 mins
Image differences available at: http://107.22.172.223:8877/0d6d3ce3900d0ca/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/1f135d7bf70fcc5/output.txt Total script time: 29.11 mins
Image differences available at: http://107.21.233.14:8877/1f135d7bf70fcc5/reftest-analyzer.html#web=eq.log |
@Snuffleupagus can you add a code comment about it's being a workaround? r+ with the comment |
…ly returning incorrect values in Firefox (issue 7188) Fixes 7188.
A comment has been added, thanks for the review! /botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/014e82520074900/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/31e1ddee5ece68b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/31e1ddee5ece68b/output.txt Total script time: 23.50 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/014e82520074900/output.txt Total script time: 27.86 mins
|
Note: Locally this patch causes a number of test "failures", all of which are completely imperceivable to the naked eye.
Fixes #7188.